Results 1 to 4 of 4
  1. #1
    Junior Member Mattdbryce's Avatar
    Join Date
    Dec 2010
    Location
    London
    Posts
    6
    Thanks
    0
    Thanked 0 Times in 0 Posts

    Portfolio website...poor coding??

    Hi guys,

    I've just finished my portfolio site, the thing is i know little about coding. I'm quite happy with the design, i'm just a little concerned on the coding side. Does anyone have any tips on how the coding on the site should read?

    Matthew Bryce | Graphic Designer

    Thanks so much!

    Matt

  2. #2
    Moderator Corrosive's Avatar
    Join Date
    May 2010
    Location
    Bristol, UK
    Posts
    980
    Thanks
    18
    Thanked 27 Times in 20 Posts
    Hi Matt

    The coding generally looks fine to me. Two points really;

    1. Empty h1 tag: Best to put some text in this and possibly hide using -9999px text indent. H1 should not be empty for SEO reasons
    2. Not much HTML text

    I have never seen unordered lists and list items used in that way but I actually can't see an issue with doing it as it is technically just a big menu on your page so, semantically, it feels OK.

  3. #3
    Senior Member creatabledesign's Avatar
    Join Date
    Mar 2010
    Location
    Swindon
    Posts
    137
    Thanks
    0
    Thanked 0 Times in 0 Posts
    Hi Matt,

    Generally the coding is looking good apart from not validating etc. However that being said, these seem to be very minor problems.

    <h1> tag empty as mentioned above and also there seems to be a lot of cases where it looks like you may be trying to add an ID to the anchor tag? As I see a lot of anchors with image#1 (number is different throughout the code though).

    Any particular reason you did this?

  4. #4
    Senior Member
    Join Date
    Nov 2009
    Location
    Colchester, Essex
    Posts
    797
    Thanks
    5
    Thanked 26 Times in 22 Posts
    Do you want people to be able to find your website? Need to look at putting some words on there or you won't be found!

Similar Threads

  1. Website CV/Portfolio
    By ann0n in forum Graphic Design Critique:
    Replies: 5
    Last Post: 12-21-2011, 09:11 AM
  2. A client coding the website themselves
    By True Graphics in forum Website Design Forum:
    Replies: 6
    Last Post: 09-21-2011, 12:37 PM
  3. Oh no not another Portfolio Website!
    By JMCDesigner in forum Website Design Critique:
    Replies: 8
    Last Post: 09-03-2009, 09:28 PM
  4. New Portfolio Website
    By mark165 in forum Website Design Critique:
    Replies: 8
    Last Post: 07-29-2009, 10:06 PM
  5. poor logo
    By CallumCopley in forum Introduction Forum:
    Replies: 21
    Last Post: 04-08-2009, 11:22 PM

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •